Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue of deconvolution #228

Open
leihouyeung opened this issue Apr 22, 2022 · 11 comments
Open

Issue of deconvolution #228

leihouyeung opened this issue Apr 22, 2022 · 11 comments

Comments

@leihouyeung
Copy link

Thanks for your great work. I got an issue during deconvolution.

Error in enrich_matrix[, ct_spot_k[m]] : subscript out of bounds
In addition: Warning messages:
1: In sparseMatrix(i = indices[] + 1, p = indptr[], x = as.numeric(x = counts[]), :
'giveCsparse' has been deprecated; setting 'repr = "T"' for you
2: In cbind(allCounts_DWLS, solDWLS) :
number of rows of result is not a multiple of vector length (arg 2)

And I also notice that there is no guideline for deconvolution in the tutorial of Giotto. Could you supply this for me?

@JunxiangXu
Copy link
Contributor

Sorry for the late reply. I am unable to replicate this error message you provided. Can you specify which command did you get the error message from? Can you also upgrade to the latest Giotto Suite version and see if it still appears?

Also, We have a tutorial on deconvolution/spatial enrichment at http://giottosuite.com/articles/analyses_deconvolution_Oct2021.html, or you can refer to the complete pipeline of visium brain dataset: http://giottosuite.com/articles/mouse_visium_brain_220426.html.

@leihouyeung
Copy link
Author

Thanks for your reply. It still didn't work on my dataset by outputting this error when I run "runDWLSDeconv":

Error in quadprog::solve.QP(Dmat = D, dvec = d, Amat = A, bvec = bzero) :
matrix D in quadratic function is not positive definite!

@gcyuan
Copy link
Collaborator

gcyuan commented Apr 30, 2022 via email

@leihouyeung
Copy link
Author

There is also another error when I applied the other dataset:

Error in eigen(if (doDykstra) R else Y, symmetric = TRUE) :
infinite or missing values in 'x'

These two datasets could be deconvolved successfully by some other methods. So I'm really confused.

On the other side, could you supply a more concise tutorial for generalized data format (like I have :1. scRNA-seq expression matrix, 2. cell-type annotation of all cells, 3. ST expression matrix and 4. coordinates of all ST spots). Because maybe your tutorial would work for your dataset, but if I want to apply this method on my dataset, it would be hard to transfer your data format to mine. That's just a suggestion. :)

@gcyuan
Copy link
Collaborator

gcyuan commented Apr 30, 2022 via email

@leihouyeung
Copy link
Author

@gcyuan Thanks for your supply, but I still have the mentioned error when running deconvolution. I have tried too many versions of Giotto for deconvolution. How about I send you the data and could you please help me apply your method for deconvolution? The link is here.
object$sc_count expression profile of scRNA-seq
object$st_count expression profile of ST
object$cell_type cell type annotation of scRNA-seq
object$st_location coordinates of ST spots

Thanks so much!

@gcyuan
Copy link
Collaborator

gcyuan commented Apr 30, 2022 via email

@gcyuan
Copy link
Collaborator

gcyuan commented May 3, 2022 via email

@leihouyeung
Copy link
Author

@gcyuan Have you tried our data on SpatialDWLS? If you deconvolved it successfully, you could share your code with me so that I could see why my code did not work. Thanks. From the report of the error, I do not really think it would be related to the OS complication.

@curiegat
Copy link

curiegat commented Jul 8, 2022

Hi @leihouyeung and @gcyuan

May I know whether the problems related to the Eigen error (Error in eigen(if (doDykstra) R else Y, symmetric = TRUE) : infinite or missing values in 'x' - #277) has been solved or not?, if it has, may I know the solution?, because currently I am working with 5 samples and 5 gene lists, and I got this error message on 4 samples with 2 gene lists. I have tried to omit and remove the NAs, but it seems like not giving any impact. I would be glad if someone could help and I'll share the data that have the error.

Thank you and cheers,

Agatha

@chrkuo
Copy link

chrkuo commented Mar 28, 2023

There is also another error when I applied the other dataset:

Error in eigen(if (doDykstra) R else Y, symmetric = TRUE) : infinite or missing values in 'x'

These two datasets could be deconvolved successfully by some other methods. So I'm really confused.

On the other side, could you supply a more concise tutorial for generalized data format (like I have :1. scRNA-seq expression matrix, 2. cell-type annotation of all cells, 3. ST expression matrix and 4. coordinates of all ST spots). Because maybe your tutorial would work for your dataset, but if I want to apply this method on my dataset, it would be hard to transfer your data format to mine. That's just a suggestion. :)

I am running DWLS and just encountered the same error. do you mind sharing what other methods helped with deconvolution to bypass this error? and what was the cause of that error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants