Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doLeidenSubCluster #66

Closed
onahman opened this issue Jul 23, 2020 · 1 comment
Closed

doLeidenSubCluster #66

onahman opened this issue Jul 23, 2020 · 1 comment

Comments

@onahman
Copy link

onahman commented Jul 23, 2020

It's a minor issue.
I am getting an error when running this function doLeidenSubCluster
Error in calculateHVG(gobject = new("giotto", raw_exprs = new("dgCMatrix", :
unused argument (difference_in_variance = 1)

seems like an easy fix.

Also, the usage example here:
https://rdrr.io/github/RubD/Giotto/man/doLeidenSubCluster.html
doLeidenSubCluster(gobject)
Doesn't work since it requires cluster_column to be specified.

@RubD
Copy link
Collaborator

RubD commented Jul 24, 2020

Thanks for letting us know. I think this could actually be fixed by changing the defaults for the hvg_param parameter to:
hvg_param = list(reverse_log_scale = T, difference_in_cov = 1, expression_values = 'normalized')
I'll do more formal tests later this week.

We haven't found a good and simple way for the individual usage examples, but we're working on that for in the next version.

@RubD RubD closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants