add indexdb integration to yjs hooks #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIS-1140 Add IndexDB integration to yjs hooks
https://github.com/yjs/y-indexeddb This will allow the document to be persisted offline. |
paulgb
reviewed
Jul 25, 2023
| return useContext(YjsContext)?.doc ?? null | ||
| export function useYDoc(): Y.Doc { | ||
| const yjsCtx = useContext(YjsContext) | ||
| if (!yjsCtx) { |
There was a problem hiding this comment.
Does React guarantee that useEffect in YDocProvider will have been called before the component that invokes useYDoc is rendered? Otherwise this will be null even if it is in the provider on the first render, no?
There was a problem hiding this comment.
We are enforcing that by not rendering the Provider's children until the useEffect has run and the ctx !== null.
There was a problem hiding this comment.
Ahhh, that makes sense, I can see how this is better!
rolyatmax
force-pushed
the
taylor/dis-1140-add-indexdb-integration-to-yjs-hooks
branch
from
3d4ef16
to
2d4115b
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 3 commits contain some small refactoring. A description for each change is in the commit messages.
Adding IndexDBProvider is still WIP