Git commit exit code is 0 if permission checks fail on .git/objects

[sirnewton01]

Create a git repository. Change the filesystem permissions to prevent writes to the .git/objects/?? files.

chmod a-w .git/objects .git/objects/??

Try committing. The commit fails with an error message.

Err: No changes staged for commit.

But, the exit code is 0, which would cause an automated script to assume that the commit succeeded.

$ echo $?
0

[driusan]

Oops.. commit ID referenced the wrong issue.

[driusan]

Actually, wait, no, that did fix it.

It dies in weird ways now, (claims "Invalid tree"), but the real git client dies in weird ways too (claims "not a git repository")