Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git show command missing #42

Closed
driusan opened this issue Jul 15, 2018 · 4 comments
Closed

git show command missing #42

driusan opened this issue Jul 15, 2018 · 4 comments
Assignees
Labels
enhancement git test suite Issues identified by the real git test suite help wanted

Comments

@driusan
Copy link
Owner

driusan commented Jul 15, 2018

4 of the remaining 6 test failures from the t0000-basic tests from git are failing because the test suite uses git show -- pretty=raw in order to verify the commit from commit-tree, which is missing

@driusan
Copy link
Owner Author

driusan commented Jul 15, 2018

If anyone wants to take a stab at this, I added https://github.com/driusan/dgit/wiki/Adding-a-git-subcommand to the wiki with instructions on how to add a new subcommand.

@driusan driusan added enhancement git test suite Issues identified by the real git test suite and removed bug labels Jul 15, 2018
@sirnewton01 sirnewton01 self-assigned this Jul 16, 2018
@sirnewton01
Copy link
Collaborator

I can pick this one off next. It seems that if we have a show command that can at least show the commit information, minus the diffs it would allow the tests to do their validation at least. Diffs seem more complicated because I don't think that dgit can yet support diffs within objects.

@driusan
Copy link
Owner Author

driusan commented Jul 16, 2018

Yeah, I don't know why they use show and not cat-file, but ignoring the diff and adding a note in status.txt about it is fine. If you want the diff, you need to use the diff-tree plumbing command, and then on the cmd side you can run printDiffs on the result.

@sirnewton01
Copy link
Collaborator

I have an initial implementation available in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement git test suite Issues identified by the real git test suite help wanted
Projects
None yet
Development

No branches or pull requests

2 participants