Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize to other storage services #213

Closed
omri374 opened this issue May 10, 2020 · 2 comments
Closed

Generalize to other storage services #213

omri374 opened this issue May 10, 2020 · 2 comments

Comments

@omri374
Copy link
Contributor

omri374 commented May 10, 2020

This repo is plain awesome. One suggestion I have is to allow a user to define the storage account in use (and remove depenency on s3 or aws). Many people don't have aws accounts and are working with other cloud providers or on-premises.

Is the dependency on the aws Python package and s3 connectivity really mandatory for using this tool? Should it should be some kind of extension?

EDIT: I see that this is actually taken care of in #162. Cool! What's keeping this PR from being merged?

@pjbull
Copy link
Member

pjbull commented May 11, 2020

Yep, this is planned in #162.

That PR needs working since the tests aren't passing yet, particularly on Windows (see #205, which is going in to that branch if you want a head start there).

Also, there aren't tests yet for each of the particular providers which need manual testing then mocks to make sure those functions work across providers and OSes.

Would love contributions there!

@pjbull
Copy link
Member

pjbull commented May 11, 2020

Closing this issue since those items are covered elsewhere.

@pjbull pjbull closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants