Skip to content

FormData as argument in send method #43

Open
chetandhembre opened this Issue Oct 3, 2012 · 3 comments

4 participants

@chetandhembre

today i try to call xmlhttprequest during that i send argument of type FormData but it is giving error as follow:

TypeError: Argument must be a string

@driverdan
Owner

FormData is part of the XHR 2 spec which node-XHR is missing most of, including FormData. This is something I'd like to add when I have a chance.

Take a look at @felixge's FormData lib for node: https://github.com/felixge/node-form-data

@Jeff-Meadows

I got this working with some hacking earlier and I'd be happy to submit a PR. In my mind, this can be done by adding node-form-data as a dependency and checking if send has been called with an instance of FormData, or by just checking data for getHeaders, pipe, and getLengthSync (and assuming objects with those properties should be treated as a FormData).

Let me know which you'd prefer.

@jacwright

👍 I was about to create this PR. Glad I checked first! This is the solution I was going to do as well. Please accept @driverdan. We need file-upload capability in our client/server SDK and this is a great solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.