Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jump vector display #8

Closed

Conversation

andenacitelli
Copy link

@andenacitelli andenacitelli commented Apr 23, 2021

It is often useful to be able to view jump vectors; this PR adds a keyword argument, plotJumps, to the plot() function, which causes it to plot all the jump vectors in a dark gray color (to avoid conflicts with the usual heatmap).

Example Output:
image

If you'd like me to open a PR to a different branch or for me to change anything, let me know.

@drlukeparry drlukeparry self-assigned this Apr 23, 2021
@drlukeparry drlukeparry added the enhancement New feature or request label Apr 23, 2021
@drlukeparry
Copy link
Owner

Thank you for this submission

In principle, I can include this perhaps as another option to show jumps between hatch vectors for better visualisation,rather than referring these globally as 'jump vectors'

Technically, due to my own implementation the order of scanning is not correct i.e. the hatch geometry then the contour geometry is collected and plotted separately rather than in the actual sequential order in the build file you would witness during scanning. I would like to correct this or provide an alternative plotting function for this and then incorporate the contribution.

@drlukeparry
Copy link
Owner

Implemented an improved sequential layer plotting visualisation. This includes jump vectors (in dash), which includes contour vectors too.

visualisation

@andenacitelli
Copy link
Author

Looks great - thanks!

@andenacitelli andenacitelli deleted the feature/jump-vectors branch July 3, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants