Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing license meta name. #19

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Apr 24, 2018

Hi @drmuey

Please review the PR.

Many Thanks.
Best Regards,
Mohammad S Anwar

@drmuey
Copy link
Owner

drmuey commented Apr 24, 2018

Thanks @manwar! This is similar to/changes what @karenetheridge already I think did so I'd like her to sign off on it too, thoughts @karenetheridge?

Also, can you change the issue tracker from rt to github issues?

@karenetheridge
Copy link
Contributor

I don't think META.yml and META.json should be committed to the repository. They are only generated via make dist in the release directory and should not appear in the local directory at all.

The Makefile.PL change is correct for license but should also contain the 'resources' metadata that is expected to appear in META.*.

@drmuey drmuey merged commit 0769d87 into drmuey:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants