Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to questions does not redirect back to entity page #65

Closed
zcmander opened this issue Jun 8, 2023 · 3 comments
Closed

Back to questions does not redirect back to entity page #65

zcmander opened this issue Jun 8, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zcmander
Copy link

zcmander commented Jun 8, 2023

If you have embedded Q&A page as a tab into entity page, like this:
image

After selecting question there is a button called Back to questions.

But that redirect the user back to all questions, not the ones that relates to the entity to begin with.

Should we embed question page under the entity page as well, so there would be no reason to have the button in the first place or is there any other ideas how to handle? Maybe carry entity reference in URL?

@zcmander zcmander changed the title Back to questions does not redirect to entity page Back to questions does not redirect back to entity page Jun 8, 2023
@drodil
Copy link
Owner

drodil commented Jun 8, 2023

There should be an entity reference in the URL when going to a question from the entity page if I remember correctly. That could be used for the back button.

@drodil
Copy link
Owner

drodil commented Jun 8, 2023

No, there's no reference in URL. Other option is to use the navigation history from browser but that might lead to weird places. Maybe adding the reference to URL could be the best option. Or some combination of these.

@drodil drodil added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jun 8, 2023
@drodil drodil closed this as completed in 85c7c24 Jun 16, 2023
@drodil
Copy link
Owner

drodil commented Jun 16, 2023

Should be fixed in 1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants