Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Difference between this entity validator and @backstage/plugin-entity-validation? #80

Open
bforbis opened this issue Feb 29, 2024 · 2 comments

Comments

@bforbis
Copy link
Contributor

bforbis commented Feb 29, 2024

I am looking to start using this plugin, however I'm a bit confused about what I should do with my existing use of @backstage/plugin-entity-validation.

I see the implementation here does not follow the same approach in @backstage/plugin-entity-validation.

The (official?) plugin seems to make a request to the catalog API for entity validation. I assume this allows for some sort of customization on entity validation by the backstage implementers?

@drodil
Copy link
Owner

drodil commented Feb 29, 2024

This was done before backstage had own entity validator available. Should probably migrate to use that.

@bforbis
Copy link
Contributor Author

bforbis commented Feb 29, 2024

One other big difference is that plugin uses @uiw/react-codemirror which stylistically looks vert different than all the other tools. Do you see that being a problem, or would you consider porting the default editor here to use codemirror?

Just another note, I tried doing the simple thing of just passing <EntityValidationPage /> as a tool in the toolbox extraTools config. This rendered the tool in the UI, but the validate button wasn't working and causing some errors.

For now, I just added a link button on that custom page to the deployed validation page at "/entity-validation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants