Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac issue #29

Merged
merged 6 commits into from
Nov 7, 2018
Merged

Mac issue #29

merged 6 commits into from
Nov 7, 2018

Conversation

droglenc
Copy link
Contributor

@droglenc droglenc commented Nov 7, 2018

Addressed issue with proper windowing in Mac OS environments.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 106

  • 25 of 31 (80.65%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 70.462%
Changes Missing Coverage Covered Lines Changed/Added Lines %
R/RFishBC-internals.R 4 6 66.67%
R/digitizeRadii.R 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
R/digitizeRadii.R 1 31.91%
Totals Coverage Status
Change from base Build 100: 0.4%
Covered Lines: 458
Relevant Lines: 650
💛 - Coveralls

@droglenc droglenc merged commit 5fb7cfb into master Nov 7, 2018
@droglenc droglenc deleted the Mac-Issue branch November 7, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@droglenc @coveralls