Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Assigned] Contributors screen #14

Closed
takahirom opened this issue Dec 25, 2017 · 9 comments · Fixed by #206
Closed

[Assigned] Contributors screen #14

takahirom opened this issue Dec 25, 2017 · 9 comments · Fixed by #206
Labels
high priority welcome contribute
Milestone
0.1.0(〜01/22)

Comments

@takahirom
Copy link
Member

takahirom commented Dec 25, 2017 •
edited

Overview

In this screen, you will see a list of contributors.
This screen may use GitHub API
Design
https://app.zeplin.io/project/5a327a64f0b20176887c556c/screen/5a539ca700a269f5c166755b
https://scene.zeplin.io/project/5a327a64f0b20176887c556c/screen/5a539ca700a269f5c166755b
@takahirom takahirom changed the title Contribution screen (without design) Contribution screen (without design, only show contributor data) Dec 25, 2017
@takahirom takahirom changed the title Contribution screen (without design, only show contributor data) Contributers screen (without design, only show contributor data) Dec 25, 2017
@takahirom takahirom changed the title Contributers screen (without design, only show contributor data) Contributors screen (without design, only show contributor data) Dec 30, 2017
@takahirom takahirom removed the to do label Jan 9, 2018
@takahirom takahirom reopened this Jan 9, 2018
@takahirom takahirom added the to do label Jan 9, 2018
@takahirom takahirom changed the title Contributors screen (without design, only show contributor data) Contributors screen Jan 9, 2018
@kaelaela
Copy link
Contributor

🙋

@konifar konifar changed the title Contributors screen [Assigned] Contributors screen Jan 13, 2018
@konifar
Copy link
Contributor

konifar commented Jan 13, 2018

@kaelaela Thanks for tackling this tough task! I assigned you! Feel free to ask us if you have any questions.

@takahirom
Copy link
Member Author

👏

@takahirom
Copy link
Member Author

@kaelaela I invited you to Zeplin Project 🎨

@kaelaela
Copy link
Contributor

@takahirom Thx ;-) I confirmed it. 👍

@takahirom takahirom added this to the 1.0.0 milestone Jan 13, 2018
@kaelaela
Copy link
Contributor

@takahirom @konifar Is this Github user's bio ?🤔
screen shot 2018-01-15 at 12 32 55

@konifar
Copy link
Contributor

konifar commented Jan 15, 2018

@kaelaela Maybe so. I'm not sure the data is included in API response though 🙇
If we can not get the bio, it's okay to implement it with the name simple line.

@kaelaela
Copy link
Contributor

@konifar Contributors API response has no bio content. 😢 Sorry, I will implement only name. 🙇 Thx.

@konifar
Copy link
Contributor

konifar commented Jan 15, 2018

Sure sure. It's okay!

@kaelaela kaelaela mentioned this issue Jan 15, 2018
Merged
@konifar konifar removed the to do label Jan 15, 2018
@rkowase rkowase mentioned this issue Jan 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority welcome contribute
Projects
None yet
Milestone
0.1.0(〜01/22)
Development

Successfully merging a pull request may close this issue.

Implement contributors screen kaelaela/conference-app-2018
3 participants
@konifar @takahirom @kaelaela