New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Assigned] Create custom view for speakers #61

Closed

takahirom opened this issue Jan 12, 2018 · 2 comments · Fixed by #133

Labels

welcome contribute

Member

takahirom commented Jan 12, 2018

Overview (Required)

Currently, we should write binding logic for speakers image and text for each session.

Screenshot

takahirom added enhancement welcome contribute labels

Member Author

takahirom commented Jan 12, 2018

We can delete this logic by creating the custom view.
https://github.com/droidkaigi/conference-app-2018/blob/ef06b6e3a95d4d7514c90c97ccb4d3f11c8c62db/app/src/main/java/io/github/droidkaigi/confsched2018/presentation/search/item/HorizontalSessionItem.kt#L44-L44
https://github.com/droidkaigi/conference-app-2018/blob/a289d1e883f5fbb6281f06812ef85c8ca57ea55d/app/src/main/java/io/github/droidkaigi/confsched2018/presentation/detail/SessionDetailFragment.kt#L67-L67
https://github.com/droidkaigi/conference-app-2018/blob/ef06b6e3a95d4d7514c90c97ccb4d3f11c8c62db/app/src/main/java/io/github/droidkaigi/confsched2018/presentation/sessions/item/SpeechSessionItem.kt#L27-L27

takahirom added the to do label

Contributor

YusukeIwaki commented Jan 13, 2018

I want to contribute to this issue 🙆‍♂️

konifar changed the title ~~Create custom view for speakers~~ [Assigned] Create custom view for speakers

YusukeIwaki mentioned this issue

Custom view for speakers summary layout #133

Merged

konifar closed this as completed in #133

konifar removed the to do label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment