Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support query monitors by tags filter #1013

Merged
merged 9 commits into from
Jun 12, 2023

Conversation

l646505418
Copy link
Contributor

@l646505418 l646505418 commented Jun 5, 2023

What's changed?

add monitorGroup in Monitor and modify query API to support group monitor

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@l646505418
Copy link
Contributor Author

Hi @tomsun28 ,I have modified the backend codes, maybe need some guys to modify frontend code

@tomsun28
Copy link
Contributor

tomsun28 commented Jun 5, 2023

用标签来进行分组怎么样,我们有标签功能,用户给监控打上特定的一类标签,然后用标签来查询过滤一组监控

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


How about grouping with tags? We have a tagging function. Users can tag a specific category of monitors, and then use tags to query and filter a group of monitors.

@l646505418
Copy link
Contributor Author

我觉得不错,hhh

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


I feel good, hhh

@l646505418
Copy link
Contributor Author

用标签来进行分组怎么样,我们有标签功能,用户给监控打上特定的一类标签,然后用标签来查询过滤一组监控

Hi,那后端接受的param是list呢还是一个json字符串?

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


How about using tags to group? We have a tag function. Users can tag a specific type of monitoring, and then use tags to query and filter a group of monitoring

Hi, is the param accepted by the backend a list or a json string?

@tomsun28
Copy link
Contributor

tomsun28 commented Jun 7, 2023

用标签来进行分组怎么样,我们有标签功能,用户给监控打上特定的一类标签,然后用标签来查询过滤一组监控

Hi,那后端接受的param是list呢还是一个json字符串?

标签数组吧,就是我们的监控查询支持一波 根据标签过滤查询

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


How about using tags to group? We have a tag function. Users can tag a specific type of monitoring, and then use tags to query and filter a group of monitoring

Hi, is the param accepted by the backend a list or a json string?

Label array, that is, our monitoring query supports a wave of filtering queries based on labels

@tomsun28 tomsun28 changed the title A feature branch 1009 support query monitors by tags filter Jun 7, 2023
@tomsun28 tomsun28 self-requested a review June 7, 2023 12:43
@tomsun28 tomsun28 added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2023
@l646505418
Copy link
Contributor Author

Hi @tomsun28 ,I have modified the code to support group by tag and query by tag list, you can review

@tomsun28
Copy link
Contributor

Hi @tomsun28 ,I have modified the code to support group by tag and query by tag list, you can review
👍 ok

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 merged commit 28c40ca into apache:master Jun 12, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants