Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix some email server config can not send message #1066

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jul 3, 2023

What's changed?

bugfix some email server config can not send message

fix #1062

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added the bugfix label Jul 3, 2023
@tomsun28 tomsun28 requested a review from zqr10159 July 3, 2023 08:07
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥又把配置加回去了

@tomsun28
Copy link
Contributor Author

tomsun28 commented Jul 3, 2023

为啥又把配置加回去了

之前 MailConfigProperties 我们自己生成的 JavaMailSender bean 缺少一些配置信息,导致某些平台发送邮件失败 见 #1062
所以这里还是使用spring的规范配置,让他自动生成 JavaMailSender bean。当用户使用页面配置邮件服务器时,我们使用页面配置信息替换 JavaMailSender 的部分参数即可。这样yml和页面两边都可以配邮件服务器,也支持yml配置它的一些特殊高级参数

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Why did you add the configuration back again

The JavaMailSender bean generated by ourselves in MailConfigProperties lacked some configuration information, which caused some platforms to fail to send emails. See #1062
So here is still using the standard configuration of spring, let him automatically generate JavaMailSender bean. When the user uses the page to configure the mail server, we can use the page configuration information to replace some parameters of JavaMailSender. In this way, mail servers can be configured on both sides of yml and the page, and some special advanced parameters of yml are also supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

email error
3 participants