Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manager] fix: can query by tags when tagValue is null #1118

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[manager] fix: can query by tags when tagValue is null #1118

merged 1 commit into from
Jul 21, 2023

Conversation

l646505418
Copy link
Contributor

@l646505418 l646505418 commented Jul 20, 2023 •
edited

What's changed?

Fix bugs that cannot query minotrs when tagValue is null

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@l646505418 l646505418 linked an issue Jul 20, 2023 that may be closed by this pull request
[BUG] <Label group display function reports an error> #1109
Closed
1 task
@tomsun28 tomsun28 linked an issue Jul 20, 2023 that may be closed by this pull request
[BUG] <When the monitoring center selects a custom tag, if the tagvalue is empty, return a 409 error> #1112
Closed
1 task
tomsun28
tomsun28 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LGTM

@tomsun28 tomsun28 merged commit b20d9b7 into master Jul 21, 2023
2 checks passed
@tomsun28 tomsun28 deleted the 1109-bug-label-group-display-function-reports-an-error branch July 21, 2023 02:49
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@l646505418 @tomsun28
[manager] fix: can query by tags when tagValue is null (#1118)
404065d
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
35d306f
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
0d2b20e
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
92fcba5
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@l646505418 @tomsun28
[manager] fix: can query by tags when tagValue is null (#1118)
364495e
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
7befaac
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
0a6f57f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
7e95a5f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@l646505418
[manager] fix: can query by tags when tagValue is null (#1118)
2390824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@l646505418 @tomsun28