config default system timezone and fix monitor status auto recover #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceilzcx
reviewed
Aug 18, 2023
| @@ -361,7 +362,7 @@ private void handlerAvailableMetrics(long monitorId, String app, CollectRep.Metr | |||
| preAlert.setStatus(CommonConstants.ALERT_STATUS_CODE_NOT_REACH); | |||
| } | |||
| } | |||
| } else if (avaAlertDefine.isRecoverNotice()) { | |||
| } else { | |||
There was a problem hiding this comment.
这边为什么把isRecoverNotice的判断去掉了？
There was a problem hiding this comment.
因为监控的可用性状态是通过发一个恢复告警来后续变更的，如果这里用 isRecoverNotice 来判断不发送恢复告警，监控的状态就不会恢复正常。所以在后面用 isRecoverNotice 对恢复告警进行处理，如果是 isRecoverNotice 为 false那就只使用此恢复告警来变更监控状态而不真正发出去
Ceilzcx
approved these changes
Aug 18, 2023
tomsun28
added a commit
that referenced
this pull request
Jan 16, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist