Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app-ping i18n #1220

Merged
merged 2 commits into from
Sep 3, 2023
Merged

add app-ping i18n #1220

merged 2 commits into from
Sep 3, 2023

Conversation

qyaaaa
Copy link
Contributor

@qyaaaa qyaaaa commented Sep 3, 2023 •
edited

What's changed?

#1212

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Sep 3, 2023
@tomsun28
Apply suggestions from code review
5d8f357 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28
tomsun28 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 merged commit 80371da into apache:master Sep 3, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@qyaaaa @tomsun28
add app-ping i18n (#1220)
078b728
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@qyaaaa
add app-ping i18n (#1220)
9ac03c8
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@qyaaaa
add app-ping i18n (#1220)
97ca5ab
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@qyaaaa
add app-ping i18n (#1220)
ba78a93
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@qyaaaa @tomsun28
add app-ping i18n (#1220)
25d17dc
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@qyaaaa
add app-ping i18n (#1220)
efadcdc
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@qyaaaa
add app-ping i18n (#1220)
f3adb12
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@qyaaaa
add app-ping i18n (#1220)
7e2fed5
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@qyaaaa
add app-ping i18n (#1220)
86216a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qyaaaa @tomsun28