Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception when sending email has special chars #1383

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Dec 4, 2023

What's changed?

  1. fix (Exception when sending email #1355)
  2. Matcher.quoteReplacement(value)会返回所有的$字符和\字符转义后的字符串,原本的matcher.appendReplacement(buffer, value); 将value字符串直接作为替换文本,蛋value中包含了正则表达式的引用符号(比如$1, $2等表示捕获组的内容),或者有反斜线\(用于转义的),它们将被Matcher类处理为特殊的元字符。这可能导致Illegal group reference错误
  3. 此外并且没有高并发情况把StringBuffer修改为StringBuilder。
  4. 增加测试用例,并且测试用例已经通过。

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

…转义。 并且没有高并发情况把StringBuffer修改为StringBuilder
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Dec 5, 2023
@tomsun28 tomsun28 added this to the v1.4.3 milestone Dec 5, 2023
@tomsun28 tomsun28 added the bugfix label Dec 5, 2023
@tomsun28 tomsun28 changed the title fix issue#1355, 和细节的修改 fix exception when sending email has special chars Dec 5, 2023
@tomsun28 tomsun28 linked an issue Dec 5, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 merged commit 1a59261 into master Dec 5, 2023
2 checks passed
@tomsun28 tomsun28 deleted the cw1241 branch December 5, 2023 05:41
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when sending email
2 participants