Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Monitoring Template Yml Metrics I18n | 监控模版指标国际化任务认领 #1212 #1461

Merged
merged 1 commit into from
Jan 1, 2024
Merged

[Task] Monitoring Template Yml Metrics I18n | 监控模版指标国际化任务认领 #1212 #1461

merged 1 commit into from
Jan 1, 2024

Conversation

tslj1024
Copy link
Contributor

@tslj1024 tslj1024 commented Jan 1, 2024

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Jan 1, 2024
@tomsun28 tomsun28 added this to the 1.4.4 milestone Jan 1, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented Jan 1, 2024

@all-contributors please add @tslj1024 for code

@allcontributors allcontributors bot mentioned this pull request Jan 1, 2024
Merged
tomsun28
tomsun28 approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomsun28 tomsun28 merged commit 3b4feaa into apache:master Jan 1, 2024
2 checks passed
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @tslj1024! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tslj1024 @tomsun28