Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix alarm trigger-times not work when alarm and recovered trigger cyclically #1468

Merged
merged 2 commits into from
Jan 4, 2024
Merged

bugfix alarm trigger-times not work when alarm and recovered trigger cyclically #1468

merged 2 commits into from
Jan 4, 2024

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jan 2, 2024

What's changed?

bugfix alarm trigger-times not work when alarm and recovered trigger cyclically

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
06fe3b0 
…cyclically

Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 added the bugfix label Jan 2, 2024
TJxiaobao
TJxiaobao approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 added this to the 1.4.4 milestone Jan 4, 2024
@tomsun28 tomsun28 linked an issue Jan 4, 2024 that may be closed by this pull request
The number of device triggers within the threshold rule does not take effect, resulting in frequent alarms #1450
Closed
1 task
@tomsun28 tomsun28 merged commit 2e01c1c into master Jan 4, 2024
2 checks passed
@tomsun28 tomsun28 deleted the bugfix-alert branch January 4, 2024 05:52
tomsun28 added a commit that referenced this pull request Jan 16, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
4d11a77 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
a5d7a5b 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
9ce5706 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
3f8125e 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
a55408b 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
884c766 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
9b08b89 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
cdac8ab 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
8dfd344 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix alarm trigger-times not work when alarm and recovered trigger …
358f88a 
…cyclically (#1468)

Signed-off-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJxiaobao TJxiaobao TJxiaobao approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

The number of device triggers within the threshold rule does not take effect, resulting in frequent alarms
2 participants
@tomsun28 @TJxiaobao