Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert define add export and import function #1499

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Conversation

yqxxgh
Copy link
Contributor

@yqxxgh yqxxgh commented Jan 18, 2024

What's changed?

Alert define add export and import function

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@yqxxgh yqxxgh added enhancement New feature or request good first pull request Good for newcomers labels Jan 18, 2024
@yqxxgh yqxxgh added this to the 1.4.5 milestone Jan 18, 2024
@a-little-fool
Copy link
Contributor

I see that the front-end and back-end builds have failed, it seems like testing has failed. I will take a closer look tomorrow morning. Thank you for your hard work. Please rest early~

Copy link
Contributor

@a-little-fool a-little-fool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-little-fool a-little-fool merged commit ba7157e into master Jan 19, 2024
2 checks passed
@a-little-fool a-little-fool deleted the export-alertDefine branch January 19, 2024 15:18
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: a-little-fool <2030509072@qq.com>
Co-authored-by: 淞筱 <105542329+a-little-fool@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants