Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix exportMonitor.monitor.tags npe #1502

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Conversation

CharlieShi46
Copy link
Contributor

@CharlieShi46 CharlieShi46 commented Jan 20, 2024

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 changed the title fix issue#1500 bugfix exportMonitor.monitor.tags npe Jan 20, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28
Copy link
Contributor

@all-contributors please add @CharlieShi46 for code

Copy link
Contributor

@tomsun28

I've put up a pull request to add @CharlieShi46! 🎉

@tomsun28 tomsun28 merged commit a0360c5 into apache:master Jan 20, 2024
2 checks passed
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: Carpe-Wang <78642589+Carpe-Wang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <exportMonitor.monitor.tags maybe null when import batch monitors>
3 participants