[collector,common,manager] Add a new monitoring type to monitor the FTP server #586 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
1 task
tomsun28
approved these changes
Jan 20, 2023
| try { | ||
| preCheck(metrics); | ||
| connect(ftpClient, ftpProtocol); | ||
| login(ftpClient, ftpProtocol); |
There was a problem hiding this comment.
Hi, should we consider access ftp without login(username and password)
| Boolean isActive; | ||
| String responseTime; | ||
| try { | ||
| long startTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
the startTime start should before ftpClient.connect
…s "start time" from the connect
# Conflicts: # collector/src/main/java/com/usthe/collector/collect/ftp/FtpCollectImpl.java
tomsun28
added a commit
that referenced
this pull request
Jan 16, 2024
…TP server #586 (#596) * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector] fix pmd error and add telnet in services * [collector,manager] ADD anonymous login and compute the responseTime's "start time" from the connect * [collector] try to fix pmd error * [collector] try to fix pmd error * [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
…TP server #586 (#596) * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector] fix pmd error and add telnet in services * [collector,manager] ADD anonymous login and compute the responseTime's "start time" from the connect * [collector] try to fix pmd error * [collector] try to fix pmd error * [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
…TP server #586 (#596) * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector,common,manager] Add a new monitoring type to monitor the FTP server * [collector] fix pmd error and add telnet in services * [collector,manager] ADD anonymous login and compute the responseTime's "start time" from the connect * [collector] try to fix pmd error * [collector] try to fix pmd error * [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
…TP server #586 (#596) [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector] fix pmd error and add telnet in services [collector,manager] ADD anonymous login and compute the responseTime's start time from the connect [collector] try to fix pmd error [collector] try to fix pmd error [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
…TP server #586 (#596) [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector] fix pmd error and add telnet in services [collector,manager] ADD anonymous login and compute the responseTime's start time from the connect [collector] try to fix pmd error [collector] try to fix pmd error [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
…TP server #586 (#596) [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector] fix pmd error and add telnet in services [collector,manager] ADD anonymous login and compute the responseTime's start time from the connect [collector] try to fix pmd error [collector] try to fix pmd error [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
…TP server #586 (#596) [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector] fix pmd error and add telnet in services [collector,manager] ADD anonymous login and compute the responseTime's start time from the connect [collector] try to fix pmd error [collector] try to fix pmd error [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
…TP server #586 (#596) [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector,common,manager] Add a new monitoring type to monitor the FTP server [collector] fix pmd error and add telnet in services [collector,manager] ADD anonymous login and compute the responseTime's start time from the connect [collector] try to fix pmd error [collector] try to fix pmd error [manager] update name, use final str Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.