Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task #614 [Add monitoring parameters for Redis Cluster and Sentinel] #647

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

hudongdong129
Copy link
Contributor

[collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Feb 19, 2023
@tomsun28
Copy link
Contributor

Great!👍👍 Thanks for pr!
Can you add a new monitoring type redis_cluster instead of modifying the existing one redis.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

Co-authored-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 merged commit 206e00d into apache:master Feb 20, 2023
tomsun28 added a commit that referenced this pull request Jan 16, 2024
…647)

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring for cluster and sentinel

* Update manager/src/main/resources/define/param/param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
…647)

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring for cluster and sentinel

* Update manager/src/main/resources/define/param/param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
…647)

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

* [collector]feature:Add monitoring for cluster and sentinel

* Update manager/src/main/resources/define/param/param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
…647)

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring for cluster and sentinel

  Update manager src main resources define param param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
…647)

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring for cluster and sentinel

  Update manager src main resources define param param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
…647)

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring for cluster and sentinel

  Update manager src main resources define param param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
…647)

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring for cluster and sentinel

  Update manager src main resources define param param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
…647)

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring parameters for Redis Cluster and Sentinel

  [collector]feature:Add monitoring for cluster and sentinel

  Update manager src main resources define param param-redis.yml

Co-authored-by: tomsun28 <tomsun28@outlook.com>

---------

Co-authored-by: hudongdong <hudongdong9406@zto.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants