A minor refactoring of the class WarehouseWorkerPoolTest #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pr. @HattoriHenzo can you help us to update this test case #565 https://github.com/dromara/hertzbeat/blob/master/alerter/src/test/java/com/usthe/alert/AlerterWorkerPoolTest.java |
|
@all-contributors please add @HattoriHenzo for code, test. |
tomsun28
approved these changes
Feb 20, 2023
|
I've put up a pull request to add @HattoriHenzo! 🎉 |
rellyrell7898
approved these changes
Mar 29, 2023
rellyrell7898
approved these changes
Mar 29, 2023
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been already provided by @TherChenYang. This PR is a minor refactoring on the test class.