Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] avoid i18nName null #845

Merged
merged 1 commit into from
Apr 6, 2023
Merged

[refactor] avoid i18nName null #845

merged 1 commit into from
Apr 6, 2023

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Apr 5, 2023 •
edited

What's changed?

Processing i18nName as null
Handling warning for idea

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 5, 2023
tomsun28
tomsun28 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@Carpe-Wang Carpe-Wang merged commit 0dd7d57 into master Apr 6, 2023
5 checks passed
@Carpe-Wang Carpe-Wang deleted the i18nName_verify branch April 6, 2023 06:27
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
Merge pull request #845 from dromara/i18nName_verify
8bf609f 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
Merge pull request #845 from dromara/i18nName_verify
a5347ba 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Carpe-Wang
Merge pull request #845 from dromara i18nName_verify
fce7fd2 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Merge pull request #845 from dromara i18nName_verify
dde9a91 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Merge pull request #845 from dromara i18nName_verify
857d000 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Merge pull request #845 from dromara i18nName_verify
97bdfb7 
[refactor] avoid i18nName null
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Merge pull request #845 from dromara i18nName_verify
127ec87 
[refactor] avoid i18nName null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Carpe-Wang @tomsun28 @gcdd1993