Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bugs. change nacos monitor to prometheus. #880

Merged
merged 6 commits into from
Apr 18, 2023
Merged

fixed bugs. change nacos monitor to prometheus. #880

merged 6 commits into from
Apr 18, 2023

Conversation

vinci-897
Copy link
Contributor

@vinci-897 vinci-897 commented Apr 14, 2023 •
edited

fixed bugs occurred when there are two consecutive slashes in prometheus response. #872
change nacos monitor from json to prometheus.
add prometheus test。

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@vinci-897
fixed bugs occurred when there are two consecutive slashes in prometh…
74cbe1c 
…eus response.

change nacos monitor from json to prometheus.
@vinci-897 vinci-897 mentioned this pull request Apr 14, 2023
Closed
1 task
@Ceilzcx Ceilzcx self-requested a review April 14, 2023 08:48
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Apr 14, 2023
@Ceilzcx Ceilzcx changed the base branch from master to dev April 15, 2023 01:58
@Ceilzcx Ceilzcx requested a review from tomsun28 April 15, 2023 01:59
tomsun28
tomsun28 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

manager/src/main/resources/define/app-nacos.yml Outdated Show resolved Hide resolved
manager/src/main/resources/define/app-nacos.yml Outdated Show resolved Hide resolved
manager/src/main/resources/define/app-nacos.yml Show resolved Hide resolved
vinci-897 and others added 4 commits April 18, 2023 15:34
@vinci-897 @tomsun28
Update manager/src/main/resources/define/app-nacos.yml
dded4d8 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
@vinci-897 @tomsun28
Update manager/src/main/resources/define/app-nacos.yml
c43ce8d 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
@vinci-897 @tomsun28
Update manager/src/main/resources/define/app-nacos.yml
f49a302 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
@vinci-897
Update ExporterParser.java
49a1eb5 
Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
@vinci-897 vinci-897 merged commit d45bf8e into apache:dev Apr 18, 2023
2 checks passed
tomsun28 added a commit that referenced this pull request Jan 16, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
bb45173 
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
bf3ee39 
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
7e127d1 
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
8f94261 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
b9ee15a 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
a13f3c5 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
adf7457 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
4d2778b 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@vinci-897 @tomsun28
fixed bugs. change nacos monitor to prometheus. (#880)
aa83961 
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <55838224+vinci-897@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

@Ceilzcx Ceilzcx Ceilzcx approved these changes

Assignees
No one assigned
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinci-897 @tomsun28 @Ceilzcx