[collector] fix dispatch concurrency bug #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
org.dromara.hertzbeat.common.entity.job.Jon 211 行 |
tomsun28
added
enhancement
tomsun28
reviewed
May 15, 2023
common/src/main/java/org/dromara/hertzbeat/common/entity/job/Job.java
Outdated
Show resolved
Hide resolved
…ob.java Signed-off-by: tomsun28 <tomsun28@outlook.com>
|
@all-contributors please add @yujianzhong520 for code |
|
I've put up a pull request to add @yujianzhong520! 🎉 |
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
org.dromara.hertzbeat.collector.dispatch.CommonDispatcher 244行
metricsSet.forEach(metricItem -> {});和
org.dromara.hertzbeat.common.entity.job.Jon 211 行
if (!metricsSet.remove(metrics)) {会出现并发错误。
迭代时出现异常，导致监控轮训任务终止。
java.util.ConcurrentModificationException: null at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1510) at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1533) at java.base/java.lang.Iterable.forEach(Iterable.java:74) at com.usthe.collector.dispatch.CommonDispatcher.dispatchCollectData(CommonDispatcher.java:244)在Job的getNextCollectMetrics返回一个新的HashSet，避免出现这个问题。
该问题在监控Mysql服务的时候能稳定重现出现。