Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common]feature:add kafka common queue #966

Merged
merged 4 commits into from
May 19, 2023

Conversation

baiban114
Copy link
Contributor

@baiban114 baiban114 commented May 18, 2023

What's changed?

Added KafkaCommonQueue.java implements the CommonQueue interface;
Added serialization and deserialization classes required for Kafka transport

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels May 18, 2023
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM👍👍

…afkaCommonDataQueue.java

Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
Copy link
Contributor

@all-contributors please add @baiban114 for code

@tomsun28 tomsun28 merged commit 56abf30 into apache:dev May 19, 2023
2 checks passed
@allcontributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @baiban114! 🎉

@baiban114 baiban114 deleted the feature#kafka_common_queue branch May 19, 2023 17:41
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants