Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Carousel Overflow on homepage and made it responsive #975

Merged
merged 1 commit into from
May 21, 2023

Conversation

eeshaanSA
Copy link
Contributor

@eeshaanSA eeshaanSA commented May 21, 2023

What's changed?

The Logo and Dromara Friends Carousel was breaking for mobile and tablet devices. check https://hertzbeat.com/
I made the nesccessary changes to make the carousel responsive.

Before the PR :

image
image

Carousels after PR gets merged :

Screencast.from.21-05-23.02.08.48.PM.IST.webm

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
@eeshaanSA
Copy link
Contributor Author

@tomsun28 please have a look 🤗

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels May 21, 2023
@eeshaanSA
Copy link
Contributor Author

eeshaanSA commented May 21, 2023

@tomsun28 needed to have to chat with you. When is the right time for you? I wont take long. Please let me know.

@tomsun28
Copy link
Contributor

@tomsun28 needed to have to chat with you. When is the right time for you? I wont take long. Please let me know.

hi i have chat in gitter with you.

@tomsun28 tomsun28 merged commit b698c5e into apache:master May 21, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants