-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateUtils.isOverlap 重叠定义问题 #3387
Comments
相关PR和issue你也看了,本质上这算是个bug的存在,因此做了修复。 @CherryRum 帮忙解释下呗~~ |
关于不向下逻辑兼容的问题,我认为:
|
是的 其实这个功能很久了,开始时候重叠的定义,是加上了meeting,这个注释中是明确我写了,而且提示用户精确的看艾伦区间划分,用户没有多少知道艾伦区间代数的,所以我一直也不想实现一版本新的完全符合定义的(太懒了),不过现在6.0我已经准备提交了新的艾伦区间的工具类,那个可能更加灵活以及精准。 |
方法名 isOverlap 是一种比较泛的概念, 确实不好定义清楚,. |
版本情况
JDK版本: openjdk_8_201
hutool版本: 5.8.21
问题描述(包括截图)
关键提交项 #2725
类似描述 #3215
isOverlap这个方法用于检查两个时间段是否有时间重叠,
5.8.9版本之前,此方法对于前后连续的两个时间段是返回false 即不重叠.
5.8.9版本之后,此方法对于前后连续的两个时间段是返回true 即重叠.
这是超乎预期的逻辑调整,
我认为是它是一种不兼容更新. 应该提供重载方法以适配最初的场景.
1.复现代码
![image](https://private-user-images.githubusercontent.com/34275580/283078319-6fcc8497-5b6c-4185-b801-5252b230d71a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3NTUwNTUsIm5iZiI6MTcxODc1NDc1NSwicGF0aCI6Ii8zNDI3NTU4MC8yODMwNzgzMTktNmZjYzg0OTctNWI2Yy00MTg1LWI4MDEtNTI1MmIyMzBkNzFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDIzNTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMxNjI5MmExYWYzZjQ3YzFjYmNmNTg5MTQxY2Y2YjE0NjAwMDgzZTY4NzI0YWQxMmVlOWIyOTA1YzljZmE2YTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lYFmL_aOUMBcC2h1PHQdopyjtzfBmchtNjoNaLsewKk)
The text was updated successfully, but these errors were encountered: