You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tboerger I stumbled upon the same problem, so I'll probably make a PR with a fix tomorrow... however, that signed yaml is deprecated, right? I can't find anything about it on the current CLI documentation (http://docs.drone.io/cli-installation/)
Would just this be acceptable then?
//Allowing to use the instance role or provide a key and secret
if p.Key != "" && p.Secret != "" {
conf.Credentials = credentials.NewStaticCredentials(p.Key, p.Secret, "")
}
client := s3.New(session.New(), conf)
Or are there other security measures we should be taking?
Maybe just ignoring the fact that the credentials are empty is enough
(Removing https://github.com/drone-plugins/drone-s3-sync/blob/master/plugin.go#L63)
But basically any plugin communicating with aws should have the ability to work with a role
The text was updated successfully, but these errors were encountered: