Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for link-names=1 #67

Closed
vasicvuk opened this issue Oct 20, 2017 · 7 comments
Closed

Add support for link-names=1 #67

vasicvuk opened this issue Oct 20, 2017 · 7 comments

Comments

@vasicvuk
Copy link

vasicvuk commented Oct 20, 2017

It should be nice to have an option to enable link_names when sending webhook request. This will enable tagging people or channels.

https://api.slack.com/incoming-webhooks

It is simple parameter in json that is sent.

@tboerger
Copy link
Contributor

Sorry, but can you explain what you are talking about? I don't get what you are requesting.

@vasicvuk
Copy link
Author

vasicvuk commented Oct 20, 2017

Slack webhooks gives option to mention someone In messages with @username. This currently is not working if you put @username In template. This is enabled by adding list_names: 1 In JSON payload.

Sample JSON:
{"text":"Hello @myname", "link_names": 1 }

This way we could get ability to post to channel and mention user created the commit

@donny-dont
Copy link
Contributor

@vasicvuk have you looked at slack-blamer? It actually uses the slack api rather than a webhook and is much more fully featured.

@vasicvuk
Copy link
Author

vasicvuk commented Oct 21, 2017

Yes but i thought that this is deprecated plugin or so because link to the Docs is not working from GitHub repo. And also it is not listed on plugins.drone.io.

On the other side link_names is Incoming webhook feature not API feature.

@tboerger
Copy link
Contributor

Next time you should mention link_names instead of list_names and clearly explain what you want to archive, than somebody else will understand it directly and can suggest a solution.

A pull request to add this option is welcome.

@vasicvuk vasicvuk changed the title Add support for list-names=1 Add support for link-names=1 Oct 23, 2017
@donny-dont
Copy link
Contributor

slack-blame isn't deprecated. We use it quite a bit internally. It might not have been updated because we internally are on an ancient version of Drone

@bradrydzewski
Copy link
Member

@vasicvuk I am going to close this issue. Please send a pull request if you want to see it implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants