Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pipeline type check to the exec command #173

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

mach6
Copy link
Contributor

@mach6 mach6 commented Jul 14, 2020

If type is not of type 'docker' produce a meaningful
error message. Other pipeline types are not currently
supported by 'drone exec'

The previous error message will likely be
"linter: invalid or missing image", if a
project is using a ssh type, for example.
The error is misleading.


example output after this change.

$ ./release/linux/amd64/drone exec                                                                                                                                                                                                                                                                                                                              
2020/07/14 15:15:00 pipeline type (ssh) is not supported with 'drone exec'

@mach6 mach6 force-pushed the master branch 2 times, most recently from 55ffb00 to b25d7f8 Compare July 14, 2020 22:27
Copy link
Contributor

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense until we found a way how to properly handle that

If type is not of type 'docker' produce a meaningful
error message. Other pipeline types are not currently
supported by 'drone exec'

The previous error message will likely be
"linter: invalid or missing image", if a
project is using a ssh type, for example.
The error is misleading.
@mach6
Copy link
Contributor Author

mach6 commented Aug 28, 2020

@tboerger @bradrydzewski Anything you need from me on the PR? It has been in an approved state for awhile now.

@tboerger tboerger merged commit bed84a3 into harness:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants