log external secret error

harness · Jun 23, 2019 · 7e23d36 · 7e23d36
1 parent 6a43a8d
commit 7e23d36
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/operator/manager/teardown.go b/operator/manager/teardown.go
@@ -138,6 +138,9 @@ func (t *teardown) do(ctx context.Context, stage *core.Stage) error {
 			break
 		}
 	}
+	if build.Started == 0 {
+		build.Started = build.Finished
+	}
 
 	err = t.Builds.Update(noContext, build)
 	if err == db.ErrOptimisticLock {

diff --git a/plugin/secret/external.go b/plugin/secret/external.go
@@ -68,7 +68,7 @@ func (c *externalController) Find(ctx context.Context, in *core.SecretArgs) (*co
 	client := secret.Client(c.endpoint, c.secret, c.skipVerify)
 	res, err := client.Find(ctx, req)
 	if err != nil {
-		logger.Trace("secret: external: cannot get secret")
+		logger.WithError(err).Trace("secret: external: cannot get secret")
 		return nil, err
 	}
 
@@ -85,7 +85,7 @@ func (c *externalController) Find(ctx context.Context, in *core.SecretArgs) (*co
 	// empty results.
 	if (res.Pull == false && res.PullRequest == false) &&
 		in.Build.Event == core.EventPullRequest {
-			logger.Trace("secret: external: restricted from forks")
+		logger.Trace("secret: external: restricted from forks")
 		return nil, nil
 	}