Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an 'empty' user is possible with drone-cli #2738

Closed
frebib opened this issue Jun 22, 2019 · 2 comments
Closed

Adding an 'empty' user is possible with drone-cli #2738

frebib opened this issue Jun 22, 2019 · 2 comments

Comments

@frebib
Copy link

frebib commented Jun 22, 2019

$ drone user ls
frebib
$ drone user add             
Successfully added user
$ drone user ls

frebib

It seems to be possible that when executing the above commands, a user with an empty name is created. It doesn't however seem possible to delete that user in the same manner. In executing this command I was expecting the implicit --help to show up, but instead I got this.

Realistically this should be guarded against on the server side, hence why I'm opening this issue here, but I suppose the cli should also prevent the user from doing this. In this situation (and this applies to all drone-cli subcommands) I would expect the cli to show usage for the subcommand and exit 1 when a non-optional argument is not provided such as the username in this case.

@strainovic

This comment has been minimized.

@bradrydzewski
Copy link

this was fixed in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants