Fix orphaned /tmp/drone directories in kubernetes #2694
Conversation
|
|
scheduler/kube/kube.go
Outdated
| var volumes []v1.Volume | ||
| source := v1.HostPathDirectoryOrCreate | ||
| volume := v1.Volume{ | ||
| Name: "local", |
There was a problem hiding this comment.
is local volume the right storage type? we are using host volume mounts with HostPathDirectoryOrCreate in the runtime. For reference https://github.com/drone/drone-runtime/blob/master/engine/kube/util.go#L137
There was a problem hiding this comment.
@bradrydzewski Is that not what I'm doing right below here in the next 5 lines? I just named it "local", but we can name it whatever we want. I tried to replicate the same functionality as the runtime. I specify the source as v1.HostpathDirectoryOrCreate on 116 and use that as the source on line 122.
There was a problem hiding this comment.
sorry, I misread the code and thought it was creating a local mount instead of a hostPath mount. That part looks good. One question I have .... does local need to be a unique name? What will happen if two pipelines run on the same machine and try to create local volumes?
There was a problem hiding this comment.
Good point on the potential name collision. I don't know if it would cause an issue or not, but I agree we should probably use a more unique or at least explicitly named volume. The name in the runtime code is obfuscated by the engine spec struct so I wasn't able copy that. I thought about maybe using the namespace name. Any other suggestions?
There was a problem hiding this comment.
@bradrydzewski I've updated the volume name to be unique. Please take a look.
|
hey there, sorry for the delay on my end, but appreciate you pushing this through. thanks! |
Details on this issue here: https://discourse.drone.io/t/drone-leaving-directories-behind-in-kubernetes/4395
Issue here: #2693
I did what I could to copy the format/structure from here: https://github.com/drone/drone-runtime/blob/master/engine/kube/util.go#L137-L183