Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-742 DecisionTableXLSToDecisionTableGuidedConverterTest fix. #22

Conversation

baldimir
Copy link
Member

@baldimir baldimir closed this Mar 17, 2015
@baldimir baldimir reopened this Mar 17, 2015
@manstis manstis self-assigned this Mar 23, 2015
@manstis
Copy link
Member

manstis commented Mar 23, 2015

Hello,

Could you please re-instate the test that checks the Model is correct after conversion? Whilst your changes for the "conditions" tests validate the data; they no longer validate the resulting Model classes. I think this is important.

Also, it'd be nice if you could use the code-style formatting we try to adhere to: https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/tree/master/ide-configuration.

Thanks,

Mike

@baldimir
Copy link
Member Author

Hi, I made formatting changes. But it looks, that the formatter config which you linked is not actual. I use Idea 14 and i.e. the spaces after and before parenthesis are not there.

Which test do you mean that I should reinstate? I didn't erase any test. I simply joined two tests that were the same . The only difference was in XLS file used and data rows that were checked at the end of the test. Everything that was tested there is still in the tests.

@manstis
Copy link
Member

manstis commented Mar 23, 2015

@manstis
Copy link
Member

manstis commented Mar 23, 2015

Sorry, my mistake. I looked at the code after your change and the test is fine.

Commits squashed and merged into master.

Thanks for the PR.

@manstis manstis closed this Mar 23, 2015
@baldimir baldimir deleted the DecTableXLSToDecTableGuidedConvTestFix branch May 29, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants