[JBRULES-3436] fix

apache · Apr 6, 2012 · f843614 · f843614
1 parent a751c8a
commit f843614
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/drools-compiler/src/main/java/org/drools/rule/builder/dialect/DialectUtil.java b/drools-compiler/src/main/java/org/drools/rule/builder/dialect/DialectUtil.java
@@ -113,7 +113,7 @@ public int compare(JavaBlockDescr o1,
         int lastAdded = 0;
 
         for (JavaBlockDescr block : blocks) {
-            if (block.getEnd() == 0) {
+            if (block.getEnd() == 0 || block.getEnd() > originalCode.length() ) {
                 // do nothing, it was incorrectly parsed, but this error should be picked up else where
                 continue;
             }

diff --git a/drools-compiler/src/test/java/org/drools/integrationtests/MiscTest.java b/drools-compiler/src/test/java/org/drools/integrationtests/MiscTest.java
@@ -10103,4 +10103,22 @@ public void testNoMvelSyntaxInFunctions() throws Exception {
 
         assertTrue(kbuilder.hasErrors());
     }
+
+    @Test
+    public void testMissingClosingBraceOnModify() throws Exception {
+        // JBRULES-3436
+        String str = "package org.drools.test;\n" +
+                "import org.drools.*\n" +
+                "rule R1 when\n" +
+                "   $p : Person( )" +
+                "   $c : Cheese( )" +
+                "then\n" +
+                "   modify($p) { setCheese($c) ;\n" +
+                "end\n";
+
+        KnowledgeBuilder kbuilder = KnowledgeBuilderFactory.newKnowledgeBuilder();
+        kbuilder.add( ResourceFactory.newByteArrayResource(str.getBytes()), ResourceType.DRL );
+
+        assertTrue( kbuilder.hasErrors() );
+    }
 }