JBRULES-3663 - using static thread pool and updating dispose logic #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
The request is valid, but the patch needs to be improved: initializing a thread pool as a static instance is to ask for trouble and also, the use of system property alone is not consistent with our architecture. We need the pool to be created per kbase or externally but not statically and the configuration in a similar way to other drools configurations. It would be great if you could send another pull request that follows these advices. |
|
Sebi, FYI: my sincere apologies for not getting to this in the last 5 months. :( Mario is now actively looking at it though (thank you Mario!). |
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.