Fix: indented keywords would fail template expansion. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
manstis
added a commit
that referenced
this pull request
Jan 14, 2013
Fix: indented keywords would fail template expansion. Thanks for the pull request.
This was referenced Sep 16, 2013
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
… Authoring -> New Item->guided rule page. (apache#170)
lucamolteni
pushed a commit
to lucamolteni/drools
that referenced
this pull request
Oct 13, 2021
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
apache#170) * KOGITO-1120 - Create simple 'greeting' example (kogito + serverless workflow) * fixed typo * Updated examples to latest serverless runtime * updated example to also add switch state * fixing spanish spelling * Renamed according to latest master changes
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
* KOGITO-5171 Update failure message link * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
In template files, whitespaces before keywords would cause exceptions.
I don't have a JIRA issue for this, but here's a link to a discussion about this issue on the Drools user mailing list:
http://drools.46999.n3.nabble.com/Why-are-indented-keywords-in-template-causing-NPE-or-DecisionTableParseException-tp4021193.html (TL;DR - "Response: Patch welcome")
Example of indented "template" keyword
template header age type logGives the exception:
org.drools.template.parser.DecisionTableParseException: Missing header
at org.drools.template.parser.DefaultTemplateContainer.parseTemplate(DefaultTemplateContainer.java:87)
Example of indented "rule" keyword
rule "Cheese fans_@{row.rowNumber}" when Person(age == @{age})Gives the exception:
java.lang.NullPointerException
at org.drools.template.parser.DefaultTemplateColumn.createCellCondition(DefaultTemplateColumn.java:67)
Patch description