JBPM-3832 - Provide API method to delete session from db #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went through the code, Maciej, it looks good. Doing persistenceContext.remove( sessionInfo ) within the transaction covers all of the possible problems. The only remotely possible problems I can foresee are ones that would have been caused by users misusing the ksession (two instances of the same ksession, for example), and those are then the users fault in that case, not the code. |
|
merged into master, thanks Marco for looking into this |
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
lucamolteni
pushed a commit
to lucamolteni/drools
that referenced
this pull request
Oct 13, 2021
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
* KOGITO-5211 Restore from previous job * Update Jenkinsfile.release Co-authored-by: Enrique Mingorance Cano <ginxaco@gmail.com> Co-authored-by: Enrique Mingorance Cano <ginxaco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request to allow deleting sessions via api when no loner needed - 2 of 3 parts (kie-api, drools and then jbpm)