JBRULES-2776 Left and Right Unlinking #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
referenced
this pull request
in tarilabs/drools
Nov 26, 2015
I think I've noticed behavior change in KieScanner automatic-update since 6.1 -> 6.2 etc. and I would like to expose my current question below, please. Documentation[1] states: If the KieScanner finds, in the Maven repository, an updated version of the Kie project used by that KieContainer it automatically downloads the new version and triggers an incremental build of the new project. From this moment all the new KieBases and KieSessions created from that KieContainer will use the new project version. I think that current* behavior "From this moment on" actually is: 1- already existing KieBase, generated with getKieBase() : it does get automatically updated. This is the use case of named KieBase or default KieBase referenced from kmodule.xml 2- already existing KieBase, generated with newKieBase() : NOT automatically updated. This is the use case of KieBase created with "custom" KieBaseConfiguration settings and NOT referencing kmodule.xml 3- any KieBase generated after the KieScanner updated, with either getKieBase() or newKieBase() : directly the newer version, simple case, indeed as already mentioned in the documentation. Behavior for already existing KieSession depends on the underlying KieBase, so it make reference to the cases described here-above. To be fully explicit, when already existing KieSession was generated directly from KieContainer.newKieSession() is case #1 because it implies the default KieBase from kmodule.xml. My question is: - IF my statements are correct, which I checked earlier by JUnit test method below [2]: I think I will submit a PR with proposals for documentation clarifications: I think statement is missing to describe what happens to already existing KieSession and KieBase; from the current description I would have assumed only "new" stuff gets up-to-date, but (fortunately!) also some type of already-existing KieSession and KieBase gets automatically updated. - ELSE I'm wrong, meaning also case #2 should be automatically updated: I think I will submit via PR the JUnit test method below [2] with different assert values, because then case #2 we think actually demonstrate a bug. Can you tell me if it's one or the other, please? =) Thank you in advance for your feedback Ciao MM * (tested against master @ 6fcacdf, version 6.4.0-SNAPSHOT) [1] http://docs.jboss.org/drools/release/6.3.0.Final/drools-docs/html_single/index.html#d0e1390 Ref. https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion
sisivy
added a commit
to sisivy/drools
that referenced
this pull request
Aug 5, 2016
fixed code indentation apache#2
mariofusco
pushed a commit
that referenced
this pull request
Aug 11, 2016
…tion (#865) * close FileInputStream at the end. Not to closing in some cases can cause IOException "To many open files". Write better message in case of IOExcepion * Update FileKieModule.java code indentation fixed * Update FileKieModule.java fixed code indentation #2 (cherry picked from commit 1615518)
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 27, 2017
Move test resources to /src/test/resources
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 27, 2017
.. XML unmarsh/marsh NEW test ignored as not everything is fully working yet.
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 28, 2017
Move test resources to /src/test/resources
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 28, 2017
.. XML unmarsh/marsh NEW test ignored as not everything is fully working yet.
tarilabs
referenced
this pull request
in tarilabs/drools
Sep 8, 2017
Fixing the remainder of the code and providing test case.
tarilabs
referenced
this pull request
in tarilabs/drools
Oct 5, 2017
danielezonca
pushed a commit
that referenced
this pull request
Jan 27, 2020
* DROOLS-4698: Managing expressions for Collections * DROOLS-4698: Managing expressions for Collections * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * DROOLS-4698: Managing expressions for Collections + Tests * Merging from origin/master * DROOLS-4698: Changes required during CR * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Changes required during Code Review * DROOLS-4698: Additional tests. * DROOLS-4698: Increase coverage (#2) Co-authored-by: Jozef Marko <jomarko@redhat.com>
mariofusco
pushed a commit
that referenced
this pull request
May 22, 2020
…time (#2899) * changed order to allow relativeResolver to be invoked first if given * expose resource resolver via DMNRutimeBuilder * reworked accordingly to https://github.com/kiegroup/drools/pull/2899#issuecomment-630854916 * test coverage (#2) * better default case (#3) Co-authored-by: tarilabs <matteo.mortari@gmail.com>
tiagobento
added a commit
to tiagobento/drools
that referenced
this pull request
Jul 29, 2021
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
New version of travel agency using data index service
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
Syncronize repos and bringing in 06 version
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
KOGITO-538: Add Keycloak security integration to spring boot - kogito…
gorky
pushed a commit
to j2eeguys/drools
that referenced
this pull request
May 21, 2022
apache#422) * RHPAM-2554 - Require the ability to define mandatory process /case variables that can only be changed by Admin * [RHPAM-2554] Ignore changes for revapi-maven-plugin (apache#2) Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
* PLANNER-2474 optaplanner CI * PLANNER-2474 Added multijob buildchain option support (apache#1) * [PLANNER-2474] optaplanner-quickstarts added to branch_config.yaml * [PLANNER-2474] Jenkinsfile.buildchain * [PLANNER-2474] Jenkinsfile.buildchain getBuildChainActionInfo method * Update Jenkinsfile.buildchain Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * quarkus mapping * [PLANNER-2474] native and lts changes * Update Jenkinsfile.buildchain Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update pull-request-native-config.yaml * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update pull-request-lts-config.yaml * Update pull-request-lts-config.yaml * Planner 2474 (apache#2) * update * fix buildchain project env * Corrected quarkus git author * updated lts config * added LTS env var * fix * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Setup job specific envs (apache#3) * fix (apache#4) * Take optaplanner-quickstarts into account (apache#5) * Update dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/VersionUtils.groovy * Update dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/templates/KogitoJobTemplate.groovy * apply settingsXmlId * Update Jenkinsfile.buildchain * optaplanner-quickstarts mapping * Update branch.yaml * Apply suggestions from code review Co-authored-by: Enrique Mingorance Cano <ginxaco@gmail.com> * Take SonarCloud into account * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Apply suggestions from code review * Update Jenkinsfile.buildchain * updated config (apache#6) * updated config * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Apply suggestions from code review * Update pull-request-config.yaml * Update pull-request-lts-config.yaml * Update pull-request-native-config.yaml * Update pull-request-native-config.yaml * Update project-dependencies.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies.yaml * Update Jenkinsfile.buildchain * Update main.yaml * moved jenkinsfile.buildchain * Update KogitoJobTemplate.groovy * Update KogitoJobTemplate.groovy * Update Jenkinsfile.buildchain * Update .ci/project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> Co-authored-by: radtriste <tradisso@redhat.com>
mariofusco
added a commit
that referenced
this pull request
Feb 14, 2024
#5682) * add antlr4 based drl parser * bump to drools 8.16.0.Beta * improve node position discovery * first c3 integration * Module reorganization (#2) * WIP * Ignore directories * Add debug. Minor modifications * WIP * Fix tests - add comments * manage null ast nodes and fix failing test * improve drl parser * Fix basic completion (#4) * Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code * Add ignored tokens to completion Co-authored-by: livio <livio.bencik@mindsmiths.com> * add constraints parsing * - Added DRLParserWrapper to store errors using DRLErrorListener (#5) - Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage. * Enhance test/grammar coverage. function import, global, exists, not (#6) * Enhance test/grammar coverage. and, or, listExpression (#7) * Enhance test/grammar coverage. matches, single quoted string, escape (#9) - Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL * Enhance test/grammar coverage. dialect, invalid lhs (#10) * Enhance test/grammar coverage. keyword collision (#11) - Add "DRL_" prefix for DRL keywords for clarification * Enhance test/grammar coverage. function, attributes, consequence (#12) * Enhance test/grammar coverage. function, attributes, consequence - better getText preserving whitespaces - resolving WARNs because of overlapping keywords * - No need to declare duplicate keywords * Enhance test/grammar coverage. OR, inline map (#13) * OpenRewrite applied for junit5 and assertj (#14) * Enhance test/grammar coverage. label, consequenceLocation, test refac… (#15) * Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice * - better test method names * [DROOLS-7253] Review and improve drools-lsp parser Visitor design (#16) * [DROOLS-7253] Review and improve drools-lsp parser Visitor design - Remove currentConstructStack. Utilize return object instead. * - Remove instance fields. Utilize return objects instead. * [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4) - Removed some unused cast * [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (#10) * [DROOLS-7285] Failed to parse and/or with parentheses in LHS (#15) * [DROOLS-7286] Failed to parse binding with || (#21) * [DROOLS-7287] Failed to parse comments in RHS (#23) * [DROOLS-7287] Failed to parse comments in RHS * - add rhs string check * [DROOLS-7515] Parser : Accept plain text in RHS (#26) * [DROOLS-7515] Parser : Accept plain text in RHS * - Handle keyword token in RHS * - Removed sysout * - Revert statementKeywords. Instead, define DRL_END with newline or EOF * - fix method name * [DROOLS-7288] Failed to parse complex parentheses (#27) * [DROOLS-7288] Failed to parse complex parentheses - bump to 8.43.0.Final * additional tests * [DROOLS-7289] Implement accumulate (#28) * [DROOLS-7296] Implement from entry-point (#30) * [DROOLS-7297] Implement import accumulate (#29) * [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (#31) * [DROOLS-7292] Implement eval (#32) * [DROOLS-7293] Implement extends (#33) * [DROOLS-7294] Implement forall (#34) * [DROOLS-7298] Implement memberOf (#35) * [DROOLS-7300] Implement positional constraint (#36) * [DROOLS-7304] Implement temporal operators (#38) - Also covers [DROOLS-7303] Implement sliding window * [DROOLS-7301] Implement query (#37) - Also partially fixes [DROOLS-7302] Implement semicolon delimiter * [DROOLS-7295] Implement from collect (#39) * [DROOLS-7305] Implement type declaration (#40) - also covers [DROOLS-7291] Implement entry-point declaration - also covers window declaration * [DROOLS-7306] Implement unification (#41) * [DROOLS-7306] Implement unification - Also [DROOLS-7307] Parse attribute agenda-group * [DROOLS-7308] Parse attribute without value - Also [DROOLS-7309] Parse attribute with parentheses * [DROOLS-7310] parse nested parentheses (#42) * [DROOLS-7310] parse nested parentheses * - Adding code commentes and explanations - Adding more nested level tests * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (#43) * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser * removed syntax examples * [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (#44) - Add some methods to call from drools code base * Move necessary files without any additional modifications * Update DRL6Expressions.g4 to ANTLR 4 (#47) * Add DescrDumperTest and fix the expression parser grammar (#48) * Add DescrDumperTest * Fix it * [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools - New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package - To enable the new parser, run `mvn test -PDRL10` - At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration * - License header - Revert an inappropriate test edit - Removed unnecessary profile - Clarify unsupported methods - Removed unnecessary bom dependency --------- Co-authored-by: mariofusco <mario.fusco@gmail.com> Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com> Co-authored-by: Livio Benčik <lbenc135@gmail.com> Co-authored-by: livio <livio.bencik@mindsmiths.com> Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
mariofusco
pushed a commit
that referenced
this pull request
Feb 14, 2024
* WIP * Ignore directories * Add debug. Minor modifications * WIP * Fix tests - add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Guys,
This is the first implementation for the left and right unlinking feature discussed here: http://blog.athico.com/2010/08/left-and-right-unlinking-community.html
I've added a configuration option that allows you to activate it, since by default it's not active.
Comments are welcome.