Bugfix for DROOLS-354 and DROOLS-540 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2014 15:43
Using WildyFly VFS, the urlPath parameter of the function is the real path to the file with no leading "/" (see method ClasspathKieProject#getPathForVFS(URL), statement String path = f.getPath();). Without the bugfix, the drive letter is stripped from the path creating a drive-relative path. If the rule archive is on another drive than the WildFly working directory, this leads to a NullPointerException in the method ClasspathKieProject#getPomPropertiesFromZipFile(String) (in the finally block, zipFile.close()).
mariofusco
added a commit
that referenced
this pull request
Sep 23, 2014
Bugfix for DROOLS-354 and DROOLS-540
Rikkola
added a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
lucamolteni
pushed a commit
to lucamolteni/drools
that referenced
this pull request
Oct 13, 2021
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a bugfix for Drools issues DROOLS-354 and DROOLS-540 on Windows using WildFly application server.
Essentially, the problem is, that the path obtained via WildFly VFS is a path (so there is no leading "/"), but the code in IoUtils checks for the leading "/", otherwise the drive letter gets stripped creating a drive-relative path. This works well when WildFly's working directory and the VFS target file is on the same drive, but fails if two different drives are involved.