[DROOLS-1139] clone EvalInvoker in EvalCondition evaluator #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| @@ -302,7 +300,7 @@ protected GroupElement clone(boolean deepClone) { | |||
| GroupElement cloned = new GroupElement(); | |||
| cloned.setType( this.getType() ); | |||
| for ( RuleConditionElement re : children ) { | |||
| cloned.addChild( deepClone && ( re instanceof GroupElement || re instanceof Pattern ) ? re.clone() : re ); | |||
| cloned.addChild( deepClone ? re.clone() : re ); | |||
There was a problem hiding this comment.
@etirelli I've found another failing test case. The problem was caused that it wasn't cloning the EvalCondition here. Adding a further "|| re instanceof EvalCondition" fixed the problem, but I honestly didn't understand why it shouldn't call clone() regardless of the type of the RuleConditionElement. Any clue about this? Is this fix ok or do you see any drawback?
|
ok to test |
|
Merged by 8eadcaaff |
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.