BZ-1327632 - Support for custom authentication in RemoteRuntimeEngine configuration #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int port = AvailablePortFinder.getNextAvailable(1025); | ||
| HttpHeaderServer server = new HttpHeaderServer(port); | ||
|
|
||
| server.start(); |
There was a problem hiding this comment.
The above code looks to me like it should be in a @Before method. And, more importantly, there seems to be no server.stop().
|
Changes from @triceo's comments applied. |
|
failed test was due to missing commit in drools repo, just pushed it as it was anyway needed for another blocker BZ |
|
jenkins retest this |
|
+1 once there are approved flags on mentioned bz |
|
GSS has approved this fix, so we can merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.redhat.com/show_bug.cgi?id=1327632
Please only merge once there is a + on the bpms-rollup-3-6.2.x flag.