Jbide 11099 master

[nickboldt]

This PR will allow you to build the org.jboss.tools.runtime.drools.detector and org.jboss.tools.runtime.drools.detector.feature and include them on your update site. Requires that you build against JBoss Tools 4.0 / Juno, which is fine since that's the version used by JBTIS, in which your next release of droolsjbpm-tools should be included.

Was able to build this locally like this:

mvn -Dmaven.test.failure.ignore=true -Dfull=true --fail-at-end -U clean install

[krisv]

Nick,

I do get issues when I try to run the build now (see below), could it be that the runtime plugin was updated but that these changes are not in this code yet?

I have two other questions as well:

• it seems the plugin has it's own version number, wouldn't it be more useful to use the same as the other components, if it's released as part of this larger update site as well?
• since this new detector plugin has a dependency on jboss tools plugins, do you know how this will impact installation? For example, if you try to install from the generated update site, I assume it will complain that those plugins are not found if you're not using JBTools and selected that plugin?

Kris

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.16.0:compile (default-compile) on project org.jboss.tools.runtime.drools.detector: Compilation failure: Compilation failure:
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[24,0]
[ERROR] public class DroolsHandler extends AbstractRuntimeDetector {
[ERROR] ^^^^^^^^^^^^^
[ERROR] The type DroolsHandler must implement the inherited abstract method IRuntimeDetectorDelegate.getVersion(RuntimeDefinition)
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[24,0]
[ERROR] public class DroolsHandler extends AbstractRuntimeDetector {
[ERROR] ^^^^^^^^^^^^^
[ERROR] The type DroolsHandler must implement the inherited abstract method IRuntimeDetectorDelegate.computeIncludedRuntimeDefinition(RuntimeDefinition)
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[24,0]
[ERROR] public class DroolsHandler extends AbstractRuntimeDetector {
[ERROR] ^^^^^^^^^^^^^
[ERROR] The type DroolsHandler must implement the inherited abstract method IRuntimeDetectorDelegate.getRuntimeDefinition(File, IProgressMonitor)
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[64,0]
[ERROR] initializeInternal(serverDefinition.getIncludedServerDefinitions(),
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getIncludedServerDefinitions() is undefined for the type RuntimeDefinition
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[88,0]
[ERROR] public RuntimeDefinition getServerDefinition(File root,
[ERROR] IProgressMonitor monitor) {
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getServerDefinition(File, IProgressMonitor) of type DroolsHandler must override or implement a supertype method
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[103,0]
[ERROR] String version = getImplementationVersion(root, files[0]);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getImplementationVersion(File, String) is undefined for the type DroolsHandler
[ERROR] /NotBackedUp/development/droolsjbpm-tools/drools-eclipse/org.jboss.tools.runtime.drools.detector/src/org/jboss/tools/runtime/handlers/DroolsHandler.java:[133,0]
[ERROR] serverDefinition.getIncludedServerDefinitions().add(sd);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getIncludedServerDefinitions() is undefined for the type RuntimeDefinition
[ERROR] 7 problems (7 errors)

[nickboldt]

1. compile failure: "runtime plugin was updated but that these changes are not in this code yet?" -- possibly, yes.
2. versioning: feel free to bump the version to 5.5 or 6.0 depending on which branch(es) receive the code.
3. dep resolution: your generated update site should simply refer to the upstream JBT site in its metadata. This is really easy to do if you use the mojo we have for both generating a pretty index.html page AND inserting references into the content.xml file.

You need a revised pom, and to rename site.xml to category.xml. Here's a sample pom.xml showing how to build the site using the new org.jboss.tools.tycho-plugins:repository-utils:0.0.1-SNAPSHOT mojo:

https://github.com/jbosstools/jbosstools-integration-tests/blob/master/site/pom.xml

The result of this change is that users can point at your site, and will automatically resolve any not-already-installed JBoss Tools stuff they need. If you need a PR for this, I can create one.

[krisv]

Thanks! it would be useful if you could update the pull request with this.

[ge0ffrey]

This file already has /target
If submodules need to exclude target, they need to copy this .ignore file: we don't want to recursively exclude target all folders.

[ge0ffrey]

+1 for the changes in drools-eclipse/pom.xml - they all look fine and in line with the rest of our build.

[nickboldt]

Replaced by #15