Skip to content

Commit

Permalink
Upgrade GWT from 2.3.0 to 2.5.0-rc1 for Section 508 compliance
Browse files Browse the repository at this point in the history
  • Loading branch information
@ge0ffrey
ge0ffrey committed Aug 28, 2012
1 parent 7ea2b9e commit bc18034
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jbpm-installer/build.xml
View file
Expand Up @@ -448,7 +448,7 @@
<delete file="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/ejb3-persistence-1.0.2.GA.jar"/>
<delete file="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/javassist-3.4.GA.jar"/>
<delete file="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/javassist-3.14.0-GA.jar"/>
<delete file="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/gwt-user-2.3.0.jar"/>
<delete file="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/gwt-user-2.5.0-rc1.jar"/>
<delete>
<fileset dir="${install.home}/target/jbpm-gwt-console-server-war/WEB-INF/lib/" includes="hornetq*.jar,netty*.jar" />
</delete>
Expand Down

4 comments on commit bc18034

@krisv
Copy link
Member

@krisv krisv commented on bc18034 Aug 28, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is updated, did we update the version of gwt in bpm console? Made me even wonder why that line is there, because if this jar can be removed safely, why is it there in the first place?

@mswiderski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was sort of misconfiguration in packaging of console server war as gwt-user should never be packaged into it - it is more of gwt UI related library rather than server side code (at least IMO, please correct me if I am wrong).
I browsed through recent builds and I don't see it any more to be packaged inside console server war, so most likely it can be removed from the installer script too.

@krisv
Copy link
Member

@krisv krisv commented on bc18034 Aug 28, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove it for now, we'll need to test this as part of the upcoming release anyway.

@ge0ffrey
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the line shouldn't have been changed. Removed is even better.

"did we update the version of gwt in bpm console?" Not in bpm-console itself, I've updated the GWT version in the droolsjbpm-parent pom, but I now see that nothing in jbpm-gwt does any GWT compilation (it does not rebuild bpm-console's GWT stuff from source, it just copies it because it doesn't need to add anything).

Please sign in to comment.